Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(trace-view): Updating docs referencing the trace view. #1270

Merged
merged 2 commits into from
May 15, 2024
Merged

docs(trace-view): Updating docs referencing the trace view. #1270

merged 2 commits into from
May 15, 2024

Conversation

Abdkhan14
Copy link
Contributor

We made the new trace view generally available and we can load spans in it.

@Abdkhan14 Abdkhan14 requested review from lizokm and a team May 13, 2024 03:40
@vercel Vercel
Copy link

vercel bot commented May 13, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
develop ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 0:06am

lizokm
lizokm approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me in terms of words. My only concern is that we're updating the billing model and the billing unit will be spans not transactions so we'll have to update that at some point

@Abdkhan14 @lizokm
Update src/docs/sdk/research/performance/index.mdx
db94b4b 
Co-authored-by: Liza Mock <lizka920@gmail.com>
@Abdkhan14
Copy link
Contributor Author

This looks fine to me in terms of words. My only concern is that we're updating the billing model and the billing unit will be spans not transactions so we'll have to update that at some point

@lizokm yes I'm aware of this. We'll update the docs when we get rid of transactions.

@Abdkhan14 Abdkhan14 enabled auto-merge (squash) May 15, 2024 00:04
@Abdkhan14 Abdkhan14 merged commit 606d1a0 into master May 15, 2024
4 of 5 checks passed
@Abdkhan14 Abdkhan14 deleted the abdk/trace-view branch May 15, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizokm lizokm lizokm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Abdkhan14 @lizokm