Fix order of init and imports for react onboarding #10020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 12 bytes ⬇️
|
Slessi
reviewed
May 14, 2024
Comment on lines
41
to
43
| // Make sure Sentry.init() is called before importing any of your other code | ||
| import App from "./App"; | ||
| import { createRoot } from "react-dom/client"; |
There was a problem hiding this comment.
Aren't all imports are evalulated first, regardless where they appear in the file? Thought you would need to make a separate file for sentry, and import it first.
There was a problem hiding this comment.
It depends a bit on what the bundlers will do, but I think you are right. Vite seems to hoist the import statements up. I will update. Thanks!
lforst
commented
May 14, 2024
Comment on lines
+6
to
+11
| import { | ||
| createRoutesFromChildren, | ||
| matchRoutes, | ||
| useLocation, | ||
| useNavigationType, | ||
| } from "react-router-dom"; |
Comment on lines
41
to
43
| // Make sure Sentry.init() is called before importing any of your other code | ||
| import App from "./App"; | ||
| import { createRoot } from "react-dom/client"; |
There was a problem hiding this comment.
It depends a bit on what the bundlers will do, but I think you are right. Vite seems to hoist the import statements up. I will update. Thanks!
vivianyentran
approved these changes
May 14, 2024
Co-authored-by: vivianyentran <20403606+vivianyentran@users.noreply.github.com>
mydea
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: getsentry/sentry-javascript#12018 (comment)