Suggest to still read the js v8 changelog despite having @sentry/migr8
#10024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will decrease total bundle size by 11 bytes ⬇️
|
lforst
changed the title
@sentry/migr8
vivianyentran
approved these changes
May 14, 2024
| @@ -20,7 +20,7 @@ Before updating to `8.x` of the SDK, we recommend upgrading to the latest versio | |||
| npx @sentry/migr8@latest | |||
| ``` | |||
|
|
|||
| Our migration tool will let you select which updates to run, and automatically update your code. In some cases, we cannot automatically change code for you. These will be marked with a `TODO(sentry)` comment instead. Make sure to review all code changes after running `@sentry/migr8`! For more details on the deprecations, see our docs on [Deprecations in 7.x](./v7-deprecations). | |||
| Our migration tool will let you select which updates to run, and automatically update your code. In some cases, we cannot automatically change code for you. These will be marked with a `TODO(sentry)` comment instead. Make sure to review all code changes after running `@sentry/migr8`! For more details on the deprecations, see our docs on [Deprecations in 7.x](./v7-deprecations). Despite having `@sentry/migr8`, we still recommend reading the migration guide, since `@sentry/migr8` does not cover all of the changes needed to migrate. | |||
There was a problem hiding this comment.
Suggested change
| Our migration tool will let you select which updates to run, and automatically update your code. In some cases, we cannot automatically change code for you. These will be marked with a `TODO(sentry)` comment instead. Make sure to review all code changes after running `@sentry/migr8`! For more details on the deprecations, see our docs on [Deprecations in 7.x](./v7-deprecations). Despite having `@sentry/migr8`, we still recommend reading the migration guide, since `@sentry/migr8` does not cover all of the changes needed to migrate. | |
| Our migration tool will let you select which updates to run, and automatically update your code. In some cases, we cannot automatically change code for you. These will be marked with a `TODO(sentry)` comment instead. Make sure to review all code changes after running `@sentry/migr8`! | |
| For more details on the deprecations, see our docs on [Deprecations in 7.x](./v7-deprecations). | |
| <Alert level="warning"> | |
| Despite having `@sentry/migr8`, we still recommend reading this migration guide, since `@sentry/migr8` does not cover all of the changes needed to migrate. | |
| </Alert> |
If there's only a few additional changes needed, it would be great if we could point those out. If not, can leave this as is.
|
I'm gonna merge this just in case you don't have time @lforst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have seen people confused about that migr8 does not change Next.js configuration for example.