Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): Remove metrics configuration for v8 #9920

Closed
wants to merge 1 commit into from

Conversation

timfish
Copy link
Contributor

@timfish timfish commented May 4, 2024

For v8 of the JavaScript SDKs, metrics features are supported without any additional configuration.

Copy link

vercel bot commented May 4, 2024

@timfish is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented May 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2024 1:13pm

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also update the version support note () to clarify that in v8 and up, metrics works out of the box with no additional configuration required.

We should also think about how to preserve info like the configuration setup for previous versions. There will probably be users who want to keep using v7 but still want to set up metrics.

@getsantry getsantry bot added the Stale label May 28, 2024
@getsantry
Copy link
Contributor

getsantry bot commented May 28, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@timfish
Copy link
Contributor Author

timfish commented May 28, 2024

Needs work

@timfish
Copy link
Contributor Author

timfish commented May 28, 2024

No longer required

@timfish timfish closed this May 28, 2024
@timfish timfish deleted the feat/metrics-configure branch May 28, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants