Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go docs #9992

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update Go docs #9992

wants to merge 2 commits into from

Conversation

cleptric
Copy link
Member

No description provided.

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 3:33pm

Copy link

codecov bot commented May 10, 2024

Bundle Report

Changes will increase total bundle size by 21.73kB ⬆️

Bundle name Size Change
sentry-docs-server 7.44MB 15.76kB ⬆️
sentry-docs-edge-server 458.61kB 90 bytes ⬆️
sentry-docs-client 6.17MB 5.88kB ⬆️

@cleptric cleptric changed the title Update Go Crons docs Update Go docs May 10, 2024
@cleptric cleptric mentioned this pull request May 10, 2024
3 tasks
Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some copyedits but lgtm!

description: "Learn how to add Sentry instrumentation to programs using the Fiber package."
---

This page shows how to add Sentry instrumentation to programs using the Fiber
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This page shows how to add Sentry instrumentation to programs using the Fiber

Already in the description which shows on the webpage now.

Comment on lines +9 to +11
For a quick reference, there is a [complete
example](https://github.com/getsentry/sentry-go/tree/master/_examples/fiber)
available directly at the Go SDK source code repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For a quick reference, there is a [complete
example](https://github.com/getsentry/sentry-go/tree/master/_examples/fiber)
available directly at the Go SDK source code repository.
The Sentry Go SDK repository has a [complete
example](https://github.com/getsentry/sentry-go/tree/master/_examples/fiber)
of how to set up Sentry for a Fiber app.

Comment on lines +13 to +15
[GoDoc-style API
documentation](https://godoc.org/github.com/getsentry/sentry-go/fiber) is also
available.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[GoDoc-style API
documentation](https://godoc.org/github.com/getsentry/sentry-go/fiber) is also
available.
For additional reference, see the [`sentryfiber` API
documentation](https://godoc.org/github.com/getsentry/sentry-go/fiber).


`sentryfiber` attaches an instance of `*sentry.Hub` (https://godoc.org/github.com/getsentry/sentry-go#Hub) to the request's context, which makes it available throughout the rest of the request's lifetime.
You can access it by using the `sentryfiber.GetHubFromContext()` method on the context itself in any of your proceeding middleware and routes.
And it should be used instead of the global `sentry.CaptureMessage`, `sentry.CaptureException`, or any other calls, as it keeps the separation of data between the requests.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And it should be used instead of the global `sentry.CaptureMessage`, `sentry.CaptureException`, or any other calls, as it keeps the separation of data between the requests.
This method should be used instead of the global `sentry.CaptureMessage`, `sentry.CaptureException`, or any other calls, as it maintains the separation of data between the requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants