[SR] Session Replay #3339
Draft
[SR] Session Replay #3339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dule Add new sentry-android-replay module
…replay-map-object-reader
…replay-map-object-reader
…replay-map-object-reader
…n-replay-public-api
…n-replay-public-api
…n-replay-public-api
…n-replay-public-api
29 tasks
…e-strategies [SR] Introduce capture strategies and handle orientation change for buffer
vaind
reviewed
May 13, 2024
Comment on lines
+43
to
+95
| override fun sendReplayForEvent( | ||
| isCrashed: Boolean, | ||
| eventId: String?, | ||
| hint: Hint?, | ||
| onSegmentSent: () -> Unit | ||
| ) { | ||
| val sampled = random.sample(options.experimental.sessionReplay.errorSampleRate) | ||
|
|
||
| if (!sampled) { | ||
| options.logger.log(INFO, "Replay wasn't sampled by errorSampleRate, not capturing for event %s", eventId) | ||
| return | ||
| } | ||
|
|
||
| val errorReplayDuration = options.experimental.sessionReplay.errorReplayDuration | ||
| val now = dateProvider.currentTimeMillis | ||
| val currentSegmentTimestamp = if (cache?.frames?.isNotEmpty() == true) { | ||
| // in buffer mode we have to set the timestamp of the first frame as the actual start | ||
| DateUtils.getDateTime(cache!!.frames.first().timestamp) | ||
| } else { | ||
| DateUtils.getDateTime(now - errorReplayDuration) | ||
| } | ||
| val segmentId = currentSegment.get() | ||
| val replayId = currentReplayId.get() | ||
| val height = recorderConfig.recordingHeight | ||
| val width = recorderConfig.recordingWidth | ||
| replayExecutor.submitSafely(options, "$TAG.send_replay_for_event") { | ||
| var bufferedSegment = bufferedSegments.removeFirstOrNull() | ||
| while (bufferedSegment != null) { | ||
| // capture without hint, so the buffered segments don't trigger flush notification | ||
| bufferedSegment.capture(hub) | ||
| bufferedSegment = bufferedSegments.removeFirstOrNull() | ||
| Thread.sleep(100L) | ||
| } | ||
| val segment = | ||
| createSegment( | ||
| now - currentSegmentTimestamp.time, | ||
| currentSegmentTimestamp, | ||
| replayId, | ||
| segmentId, | ||
| height, | ||
| width, | ||
| BUFFER | ||
| ) | ||
| if (segment is ReplaySegment.Created) { | ||
| segment.capture(hub, hint ?: Hint()) | ||
|
|
||
| // we only want to increment segment_id in the case of success, but currentSegment | ||
| // might be irrelevant since we changed strategies, so in the callback we increment | ||
| // it on the new strategy already | ||
| onSegmentSent() | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Is there a plan to use eventId here? AFAICT, event-replay mapping is done via trace context rather than any field. The argument here is used just for logging
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog
just to trigger CI for now