Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.x Cleanup #3419

Merged
merged 5 commits into from
May 14, 2024
Merged

8.x Cleanup #3419

merged 5 commits into from
May 14, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented May 14, 2024

#skip-changelog

📜 Description

  • Isolate wrapCallable and wrapSupplier by default and remove non isolated variant for now. We can add it back if customers ask for it.
  • Fix webflux tests that now report suppressed exceptions
  • Remove old TODOs

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented May 14, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7894e4e

Copy link
Contributor

github-actions bot commented May 14, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 395.04 ms 463.65 ms 68.61 ms
Size 1.70 MiB 2.28 MiB 596.34 KiB

Baseline results on branch: 8.x.x

Startup times

Revision Plain With Sentry Diff
3e1e45b 373.72 ms 439.33 ms 65.60 ms
9f2c855 424.20 ms 506.34 ms 82.14 ms

App size

Revision Plain With Sentry Diff
3e1e45b 1.70 MiB 2.28 MiB 596.32 KiB
9f2c855 1.70 MiB 2.28 MiB 596.32 KiB

Previous results on branch: feat/fix-tests-8.x

Startup times

Revision Plain With Sentry Diff
d026715 404.13 ms 478.52 ms 74.40 ms
1e4933d 389.54 ms 471.98 ms 82.44 ms

App size

Revision Plain With Sentry Diff
d026715 1.70 MiB 2.28 MiB 596.32 KiB
1e4933d 1.70 MiB 2.28 MiB 595.98 KiB

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@adinauer adinauer merged commit 6c31cc0 into 8.x.x May 14, 2024
21 checks passed
@adinauer adinauer deleted the feat/fix-tests-8.x branch May 14, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants