Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore current thread with mechanism for abnormal crash detection #3420

Merged
merged 2 commits into from
May 14, 2024
Merged

Ignore current thread with mechanism for abnormal crash detection #3420

merged 2 commits into from
May 14, 2024

Conversation

adinauer
Copy link
Member

@adinauer adinauer commented May 14, 2024 •
edited

#skip-changelog

馃摐 Description

馃挕 Motivation and Context

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

馃敭 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

Messages
馃摉 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 馃毇 dangerJS against 4deac29

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

Performance metrics 馃殌

聽 Plain With Sentry Diff
Startup time 377.90 ms 467.51 ms 89.61 ms
Size 1.70 MiB 2.28 MiB 596.34 KiB

Baseline results on branch: feat/fix-tests-8.x

Startup times

Revision Plain With Sentry Diff
1e4933d 389.54 ms 471.98 ms 82.44 ms

App size

Revision Plain With Sentry Diff
1e4933d 1.70 MiB 2.28 MiB 595.98 KiB

Previous results on branch: feat/fix-abnormal-crash-detection

Startup times

Revision Plain With Sentry Diff
864f14a 369.00 ms 383.27 ms 14.27 ms

App size

Revision Plain With Sentry Diff
864f14a 1.70 MiB 2.28 MiB 595.99 KiB

@adinauer
Copy link
Member Author

  • without this PR something that shouldn't be marked as crash will likely be marked as such
  • with this PR something that sould be marked might no longer be marked

If we start detecting problems, we should revisit this change.

@adinauer adinauer merged commit 7894e4e into feat/fix-tests-8.x May 14, 2024
19 of 21 checks passed
@adinauer adinauer deleted the feat/fix-abnormal-crash-detection branch May 14, 2024 13:09
adinauer added a commit that referenced this pull request May 14, 2024
@adinauer
8.x Cleanup (#3419)
6c31cc0 
* fix webflux tests that are now reporting a suppressed exception

* wrapCallable and wrapSupplier now isolate by default, non isolation variant has been removed for now

* cleanup TODOs

* Ignore current thread with mechanism for abnormal crash detection (#3420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romtsn romtsn romtsn approved these changes

@stefanosiano stefanosiano Awaiting requested review from stefanosiano

@markushi markushi Awaiting requested review from markushi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adinauer @romtsn