feat(replay): Use unwrapped setTimeout to avoid e.g. angular change detection
#11924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
billyvg
force-pushed
the
fn/replay-unwrapped-setTimeout-billy
branch
from
0c5bfa2
to
6940018
Compare
|
|
mydea
approved these changes
May 16, 2024
billyvg
force-pushed
the
fn/replay-unwrapped-setTimeout-billy
branch
from
c4cf4ec
to
188f306
Compare
This moves some code around in `browser-utils` so we can-reuse the logic for getting the unwrapped fetch implementation to also get the unwrapped `setTimeout` implementation. E.g. Angular wraps this for change detection, which can lead to performance degration.
This reverts commit 78221f5.
…rted as early as possible
billyvg
force-pushed
the
fn/replay-unwrapped-setTimeout-billy
branch
from
188f306
to
8cd00ba
Compare
billyvg
commented
May 21, 2024
Comment on lines
+22
to
+24
| function isNative(func: Function): boolean { | ||
| return func && /^function\s+\w+\(\)\s+\{\s+\[native code\]\s+\}$/.test(func.toString()); | ||
| } |
There was a problem hiding this comment.
I added this, which is a generic version of this: https://github.com/getsentry/sentry-javascript/blob/develop/packages/browser/src/transports/utils.ts#L56-L58
Without this tracing/metrics/web-vitals-fid was failing consistently. Is the sandboxed version just too slow for our browser tests? cc @mydea
There was a problem hiding this comment.
hmm this looks reasonable. TBH the web-vitals tests are a bit of a black box to me, they appear/are brittle overall 😬 if that makes it pass, all good from my POV!
billyvg
added a commit
that referenced
this pull request
May 22, 2024
This makes the `isNativeFetch` check a bit more generic/naive. It no longer checks that the function name matches `fetch` explicitly, but I think thats ok. Follow-up to #11924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure we use the native, unwrapped
setTimeoutimplementation of the browser. Some environments, e.g. Angular, monkey patch this for their change detection, leading to performance issues (possibly). We have already changed this in rrweb, but we also have some usage of this in replay itself.This PR should work fine, however all test fail today because we heavily use
jest.useFakeTimers(), which basically monkey patches fetch too. So with this change, we do not use the patched timers, leading to everything blowing up 🤯Based on #11864
Depends on #11899