Warn when transaction entered without calling start_transaction
#3003
+35
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonpirker
approved these changes
Apr 23, 2024
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transaction-not-started-warning
branch
from
00c2bc7
to
5cd3884
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transaction-sampled-debug-message
branch
from
a090a5c
to
f8586eb
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transaction-not-started-warning
branch
from
5cd3884
to
f1346b0
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transaction-sampled-debug-message
branch
from
f8586eb
to
d0fc544
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transaction-not-started-warning
branch
from
f1346b0
to
84ab96a
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transaction-sampled-debug-message
branch
from
d0fc544
to
534a301
Compare
Base automatically changed from
szokeasaurusrex/transaction-sampled-debug-message
to
master
April 25, 2024 13:40
antonpirker
requested changes
Apr 30, 2024
…ransaction` Users who enter a transaction without calling `start_transaction` likely intended to start the transaction, since without a call to `start_transaction`, their transaction will not get sent to Sentry. This warning message clarifies this behavior, and could help avoid the confusion that led to issue #2990. Also, add tests to ensure the message is logged.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transaction-not-started-warning
branch
from
84ab96a
to
314ef01
Compare
|
Made the requested change @antonpirker |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change should prevent confusion like what led to #2990 being opened.