Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(performance): queues module destination search #70816

Merged
merged 7 commits into from
May 14, 2024

Conversation

edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented May 13, 2024

Updates the search bar in the Queues module landing page to fully function:

  • Search bar placeholder text has been updated
  • Search bar applies a substring search on the messaging.destination.name tag/column
  • Destinations table was updated to respond to search.
  • Charts were updated to no longer directly get fetch destination from the query params. Instead this is now passed as a prop. This was needed because the charts on the landing page should not respond to the search bar (same behaviour as other modules).

There's some "sort" and "time spent" placeholders in this pr that doesn't need to be included (sorry). I have a subsequent pr to complete those, but I can pull out of this pr if needed.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 13, 2024
Comment on lines +50 to +52
const sort =
decodeSorts(query[QueryParameterNames.DOMAINS_SORT]).filter(isAValidSort).at(0) ??
DEFAULT_SORT;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is placeholder for now as I'm working on completing the table sorting. (DOMAINS_SORT will be replaced to something more appropriate). There's a few more placeholders below that will also be taken care of in a future pr.

Can remove from this pr if needed.

@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review May 14, 2024 13:59
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner May 14, 2024 13:59
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small comments, looks good to me

@edwardgou-sentry edwardgou-sentry merged commit 2ecee6e into master May 14, 2024
41 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/queues-module-destination-search branch May 14, 2024 19:44
Copy link

sentry-io bot commented May 15, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: �[2mexpect(�[22m�[31mjest.fn()�[39m�[2m).�[22mtoHaveBeenCalledWith�[2m(�[22m�[32m...expected�[39m... Object.?(queuesTable.spec.tsx) View Issue
  • ‼️ Error: useLocation() may be used only in the context of a component. useLocation(useLocation.tsx) View Issue
  • ‼️ Error: useLocation() may be used only in the context of a component. useLocation(useLocation.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants