Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crons): Better typing on processing errors #70825

Conversation

evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented May 13, 2024

Uses typed dicts to represent the various processing errors.

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner May 13, 2024 23:10
@evanpurkhiser evanpurkhiser requested review from davidenwang and removed request for a team May 13, 2024 23:10
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 13, 2024
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-crons-better-typing-on-processing-errors branch from 7325db0 to c9e0776 Compare May 13, 2024 23:13
Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 78.51852% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 58.43%. Comparing base (985c314) to head (162877e).
Report is 9 commits behind head on master.

❗ Current head 162877e differs from pull request most recent head 33ae026. Consider uploading reports for the commit 33ae026 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #70825       +/-   ##
===========================================
- Coverage   91.36%   58.43%   -32.94%     
===========================================
  Files        2862     6469     +3607     
  Lines      178863   290265   +111402     
  Branches    31910    50087    +18177     
===========================================
+ Hits       163411   169603     +6192     
- Misses      15451   120218   +104767     
- Partials        1      444      +443     
Files Coverage Δ
src/sentry/monitors/processing_errors/manager.py 35.86% <100.00%> (-60.87%) ⬇️
src/sentry/monitors/processing_errors/errors.py 92.56% <95.41%> (-6.16%) ⬇️
src/sentry/monitors/consumers/monitor_consumer.py 19.42% <0.00%> (-71.72%) ⬇️

... and 5616 files with indirect coverage changes

@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-crons-better-typing-on-processing-errors branch 2 times, most recently from 33ae026 to 4330654 Compare May 14, 2024 20:57
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/feat-crons-better-typing-on-processing-errors branch from c83571e to 8445bf9 Compare May 14, 2024 21:04
@evanpurkhiser evanpurkhiser enabled auto-merge (squash) May 14, 2024 21:07
@evanpurkhiser evanpurkhiser merged commit 7db6de1 into master May 14, 2024
48 checks passed
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/feat-crons-better-typing-on-processing-errors branch May 14, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants