fix(query-builder): Improve the stability of token keys #70828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
force-pushed
the
malwilley/fix/search-text-token-type
branch
from
59f27d8
to
bdf9b20
Compare
malwilley
force-pushed
the
malwilley/fix/search-text-token-type
branch
from
bdf9b20
to
d4b21e8
Compare
malwilley
commented
May 14, 2024
| // XXX(malwilley): SearchQueryBuilderInput updates state in the render | ||
| // function which causes an act warning despite using userEvent.click. | ||
| // Cannot find a way to avoid this warning. | ||
| jest.spyOn(console, 'error').mockImplementation(jest.fn()); |
There was a problem hiding this comment.
Updating the state in a useEffect makes this warning go away, but does cause other issues with having a stale value for a render cycle so I don't want to do that. I tried wrapping everything I could in act to no avail 😞
Hoping I can eventually get to the bottom of this, but throwing in the towel for now
Bundle ReportChanges will decrease total bundle size by 8 bytes ⬇️
|
armenzg
approved these changes
May 14, 2024
scttcper
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the cursor would jump around when entering a free text portion due to the component remounting because the key changed. This makes some changes to avoid keys changing as much as possible:
{type}:{cursor_location}to{type}:{type_index}