common: free ctx_gguf when exiting llama_control_vector_load_one #7285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctx_gguf is initialized by gguf_init_from_file. It appears to be otherwise unused throughout the function. Someone more familar with the code might want to consider if gguf_init_from_file is necessary at all. But in the mean time, free the context when exiting so we don't leak memory.
|
There are more leaks in this function. #6289 has the fixes. |
mofosyne
added
bugfix
|
do we use valgrind here and should we? |
|
This particular one was found by static analysis. The others I sent recently were found by ASAN. It's a lot faster than valgrind. |
|
@stevegrubb looks like it might take a while for #6289 to be merged in. You may want to check if any of the leaks fixes from there is directly related to this PR and move it over, then it would make sense to merge this in. |
|
@mofosyne looks like the referenced patch contains the fix. My personal taste is not to mix features and bug fixes so that bug fixes can be cherry picked if needed. I'll close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctx_gguf is initialized by gguf_init_from_file. It appears to be otherwise unused throughout the function. Someone more familar with the code might want to consider if gguf_init_from_file is necessary at all. But in the mean time, free the context when exiting so we don't leak memory.