-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
avoid to get prompt in infill mode and embedding mode #7286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofosyne
added
examples
Review Complexity : Low
Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
server
labels
May 15, 2024
The embedding CI seems to be failing |
I will test it |
It turns out I misunderstood the way embedding is. I think it's sentence embedding model mode. |
I try this new pr with deepseek code model, it seems fine. |
@ggerganov @mofosyne hi, plz have a look. This will block the infill mode. I want to pr support for deepseek code model as well after this pr. |
ggerganov
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
examples
Review Complexity : Low
Trivial changes to code that most beginner devs (or those who want a break) can tackle. e.g. UI fix
server
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run server with command './server -m ../1.3b-instruct.gguf --port 8760'
and then run a py client below to get the result.
`import asyncio
import aiohttp
import json
import time
prompt = 'finish the code completion:'
input_prefix = 'def bubbleSort()\n'
async def test():
async with aiohttp.ClientSession() as session:
start_time = time.time()
asyncio.run(test())`
but I get a error:
{'error': {'code': 400, 'message': 'Either "prompt" or "messages" must be provided', 'type': 'invalid_request_error'}} Elapsed time: 0.0010190010070800781 seconds
I read the code and find out We don't need to get prompt when in infill mode and embedding mode.
So I add a if for the infill mode and embedding mode. It seems fine after I add the code.