Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vulkan Embedding Fix #7360

Merged
merged 4 commits into from
May 19, 2024
Merged

Vulkan Embedding Fix #7360

merged 4 commits into from
May 19, 2024

Conversation

0cc4m
Copy link
Collaborator

@0cc4m 0cc4m commented May 18, 2024

  • Fix empty Vulkan host buffers
  • Fix embedding calls by adding matmul fp16 fp32 shader
  • Fix matmul shader alignment
  • Remove deprecated tensor->backend uses in Vulkan code

Fixes #7130

0cc4m added 2 commits May 18, 2024 09:51
@0cc4m
Fix empty Vulkan host buffers
179103c 
Add fp32 fp16 matmul shader

Fix matmul shader alignment
@0cc4m
Remove deprecated tensor->backend uses
8dbde1f
@0cc4m 0cc4m mentioned this pull request May 18, 2024
Closed
@mofosyne mofosyne added Vulkan Issues specific to the Vulkan backend bugfix fixes an issue or bug Review Complexity : High Generally require indepth knowledge of LLMs or GPUs labels May 18, 2024
@github-actions github-actions bot added the python python script changes label May 18, 2024
@0cc4m 0cc4m merged commit f030ec1 into master May 19, 2024
74 checks passed
@0cc4m 0cc4m deleted the 0cc4m/vulkan-embedding-fix branch May 19, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slaren slaren slaren approved these changes

Assignees
No one assigned
Labels
bugfix fixes an issue or bug python python script changes Review Complexity : High Generally require indepth knowledge of LLMs or GPUs Vulkan Issues specific to the Vulkan backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embedding fails to run on vulkan backend
3 participants
@0cc4m @slaren @mofosyne