Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cron table language #6759

Merged
merged 7 commits into from
Jun 7, 2024
Merged

Add Cron table language #6759

merged 7 commits into from
Jun 7, 2024

Conversation

Nixinova
Copy link
Contributor

Description

Adds highlighting for Cron files of file name crontab.

Checklist:

  • I am adding a new language.
    • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • I have included a real-world usage sample for all extensions added in this PR:
    • I have included a syntax highlighting grammar:
    • [❌] I have added a color
      • Don't know what to put, there's no logo or company involved.
    • [❌] I have updated the heuristics to distinguish my language from others using the same extension.

@Nixinova Nixinova requested a review from a team as a code owner March 17, 2024 10:21
@Alhadis
Copy link
Collaborator

Alhadis commented Mar 17, 2024

Don't know what to put, there's no logo or company involved.

Then fallback on some artistic license. 😉 I'd use the colour of a manilla folder. *Rationale: Tables and scheduled tasks evoke images of dusty old offices with stuff that needs to be done. Hell, this works: #ead7ac.

Otherwise, looks good. TextMate's crontab grammar is pretty solid. I've been using it in Atom without a hitch:

Screen Shot 2024-03-17 at 11 34 15 pm

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
Nixinova and others added 4 commits March 18, 2024 18:17
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
@Nixinova
Copy link
Contributor Author

Nixinova commented Mar 18, 2024

* linguist.git_submodule.cron.tmbundle
  version: f027bc74d926b[8](https://github.com/github-linguist/linguist/actions/runs/8321971057/job/22769019563?pr=6759#step:6:9)bdc0bfaac22a41[9](https://github.com/github-linguist/linguist/actions/runs/8321971057/job/22769019563?pr=6759#step:6:10)d351bf60edd, filename: /home/runner/work/linguist/linguist/vendor/licenses/git_submodule/cron.tmbundle.dep.yml, license: unknown, allowed: false
    - license needs review: unknown

Unsure what to do here. The license of the repo is the following, which is a generic permissive free license:

Permission to copy, use, modify, sell and distribute this
software is granted. This software is provided "as is" without
express or implied warranty, and with no claim as to its
suitability for any purpose.

What needs to be put as the license for this?

@Alhadis
Copy link
Collaborator

Alhadis commented Apr 9, 2024

Unsure what to do here. The license of the repo is the following, which is a generic permissive free license

This is the usual license TextMate uses for its grammar repositories; it's a permissive license that's been reviewed and whitelisted in other grammars hosted by the @textmate org.

What needs to be put as the license for this?

cron.tmbundle.dep.yml should have the following contents:

---
name: cron.tmbundle
version: f027bc74d926b8bdc0bfaac22a419d351bf60edd
type: git_submodule
homepage: https://github.com/textmate/cron.tmbundle
license: permissive
licenses:
- sources: README.mdown
  text: "If not otherwise specified (see below), files in this repository fall under
    the following license:\n\n\tPermission to copy, use, modify, sell and distribute
    this\n\tsoftware is granted. This software is provided "as is" without\n\texpress
    or implied warranty, and with no claim as to its\n\tsuitability for any purpose.\n\nAn
    exception is made for files in readable text which contain their own license information,
    or files where an accompanying file exists (in the same directory) with a “-license”
    suffix added to the base-name name of the original file, and an extension of txt,
    html, or similar. For example “tidy” is accompanied by “tidy-license.txt”."
notices: []

🤔 …however, I'm not sure why bundle exec licensed isn't picking up the license body automatically when it (ostensibly) had no issues with c.tmbundle.dep.yml.

@lildude, hulp.

@lildude
Copy link
Member

lildude commented Apr 9, 2024

The cached file has the correct content, we just need to manually set the license as licensed struggles a bit with so cases like this.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude added this pull request to the merge queue Jun 7, 2024
Merged via the queue into github-linguist:master with commit 03c51e9 Jun 7, 2024
5 checks passed
@Nixinova Nixinova deleted the crontab branch June 8, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support crontab syntax
3 participants