-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Logisim #6786
Add Logisim #6786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is standard XML, the extension should be added to the XML language entry. We try to limit the splitting of things like XML and JSON to new entries only when they deviate and have their own grammar.
The samples/Logisim/astro8_cpu.circ
sample is also way too big. Please remove it or replace it with a smaller sample.
Sounds like it'd be appropriate to convert this PR to add the |
- remove astro8 example - move .circ examples to samples/XML - remove Logisim languages.yml entry - add .circ extension to XML entry
Alrighty, updated- lmk if anything looks off with this |
@@ -0,0 +1,353 @@ | |||
<?xml version="1.0" encoding="UTF-8" standalone="no"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@turtlebasket Are there many .circ
files that lack an XML header? If not, then these files should be classified correctly as XML on GitHub, as Linguist has a dedicated strategy for recognising files that begin with the line
<?xml version=
If many .circ
files in-the-wild lack these headers and aren't receiving any highlighting, then this addition is still valid (and you can dismiss this feedback).
The search provided in the body of this PR includes the As such, this PR appears to be completely unnecessary, and would in fact cause incorrect classification and not correct any. Closing as this is not needed. |
Description
Adding support for Logisim (Evolution) files. Logisim is a popular FOSS tool for digital system design, typically used for educational purposes. Logisim files are actually just XML but contain circuit logic that can be viewed and simulated in Logisim, making the
.circ
format somewhat comparable to.ipynb
.Checklist:
I am adding a new extension to a language.
I am adding a new language.
#008016
I am fixing a misclassified language
I am changing the source of a syntax highlighting grammar
I am updating a grammar submodule
I am adding new or changing current functionality
I am changing the color associated with a language