Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dune (OCaml build system) #6814

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kisaragi-hiu
Copy link

Description

Dune is a build system for OCaml, used in a large number of OCaml projects. This PR adds classification and syntax highlighting support for it.

I specified ace_mode: lisp because Dune is an Sexp-based language. I'm guessing that this is appropriate.

Checklist:

@kisaragi-hiu kisaragi-hiu requested a review from a team as a code owner May 6, 2024 17:04
@kisaragi-hiu kisaragi-hiu changed the title Add Dune Add Dune (OCaml build system) May 14, 2024
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as pending popularity as the two workspace files aren't sufficient yet.

ace_mode: lisp
filenames:
- dune
- dune-file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is nowhere near popular enough for inclusion. Its existence in this PR will significantly delay it being merged whilst we wait for popularity to be met. I recommend removing it. Users can use an override until popularity is sufficient for addition later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants