-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UncheckedRangeDomainPoleErrors: add missing cases #572
Open
knewbury01
wants to merge
3
commits into
github:main
Choose a base branch
from
knewbury01:knewbury01/fix-193
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
48 changes: 30 additions & 18 deletions
48
c/common/test/rules/uncheckedrangedomainpoleerrors/UncheckedRangeDomainPoleErrors.expected
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,30 @@ | ||
| test.c:4:3:4:6 | call to acos | Domain error in call to acos: the argument has a range -1.1...-1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.c:8:3:8:6 | call to acos | Domain error in call to acos: the argument has a range 1.1...1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.c:9:3:9:6 | call to asin | Domain error in call to asin: the argument has a range -1.1...-1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.c:13:3:13:6 | call to asin | Domain error in call to asin: the argument has a range 1.1...1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.c:14:3:14:7 | call to atanh | Domain error in call to atanh: the argument has a range -1.1...-1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.c:18:3:18:7 | call to atanh | Domain error in call to atanh: the argument has a range 1.1...1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.c:19:3:19:7 | call to atan2 | Domain error in call to atan2: both arguments are equal to zero. | | ||
| test.c:23:3:23:5 | call to pow | Domain error in call to pow: both arguments are equal to zero. | | ||
| test.c:27:3:27:5 | call to pow | Domain error in call to pow: both arguments are less than zero. | | ||
| test.c:33:3:33:7 | call to acosh | Domain error in call to acosh: argument is less than 1. | | ||
| test.c:34:3:34:7 | call to ilogb | Domain error in call to ilogb: argument is equal to zero. | | ||
| test.c:37:3:37:5 | call to log | Domain error in call to log: argument is negative. | | ||
| test.c:40:3:40:7 | call to log10 | Domain error in call to log10: argument is negative. | | ||
| test.c:43:3:43:6 | call to log2 | Domain error in call to log2: argument is negative. | | ||
| test.c:46:3:46:6 | call to sqrt | Domain error in call to sqrt: argument is negative. | | ||
| test.c:49:3:49:7 | call to log1p | Domain error in call to log1p: argument is less than 1. | | ||
| test.c:52:3:52:6 | call to logb | Domain error in call to logb: argument is equal to zero. | | ||
| test.c:55:3:55:8 | call to tgamma | Domain error in call to tgamma: argument is equal to zero. | | ||
| test.c:6:3:6:6 | call to acos | Domain error in call to 'acos': the argument has a range -1.1...-1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.c:10:3:10:6 | call to acos | Domain error in call to 'acos': the argument has a range 1.1...1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.c:11:3:11:6 | call to asin | Domain error in call to 'asin': the argument has a range -1.1...-1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.c:15:3:15:6 | call to asin | Domain error in call to 'asin': the argument has a range 1.1...1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.c:16:3:16:7 | call to atanh | Domain error in call to 'atanh': the argument has a range -1.1...-1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.c:18:3:18:7 | call to atanh | Domain error in call to 'atanh': the argument has a range 1.1...1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.c:19:3:19:7 | call to atan2 | Domain error in call to 'atan2': both arguments are equal to zero. | | ||
| test.c:23:3:23:5 | call to pow | Domain error in call to 'pow': both arguments are equal to zero. | | ||
| test.c:27:3:27:5 | call to pow | Domain error in call to 'pow': both arguments are less than zero. | | ||
| test.c:32:3:32:7 | call to acosh | Domain error in call to 'acosh': argument is less than 1. | | ||
| test.c:33:3:33:7 | call to ilogb | Domain error in call to 'ilogb': argument is equal to zero. | | ||
| test.c:36:3:36:5 | call to log | Domain error in call to 'log': argument is negative. | | ||
| test.c:38:3:38:7 | call to log10 | Domain error in call to 'log10': argument is negative. | | ||
| test.c:40:3:40:6 | call to log2 | Domain error in call to 'log2': argument is negative. | | ||
| test.c:42:3:42:6 | call to sqrt | Domain error in call to 'sqrt': argument is negative. | | ||
| test.c:45:3:45:7 | call to log1p | Domain error in call to 'log1p': argument is less than 1. | | ||
| test.c:47:3:47:6 | call to logb | Domain error in call to 'logb': argument is equal to zero. | | ||
| test.c:50:3:50:8 | call to tgamma | Domain error in call to 'tgamma': argument is equal to zero. | | ||
| test.c:56:3:56:5 | call to abs | Range error in call to 'abs': argument is most negative number. | | ||
| test.c:57:3:57:6 | call to fmod | Domain error in call to 'fmod': y is 0. | | ||
| test.c:59:3:59:7 | call to frexp | Unspecified error in call to 'frexp': Arg is Nan or infinity and exp is unspecified as a result. | | ||
| test.c:60:3:60:7 | call to frexp | Unspecified error in call to 'frexp': Arg is Nan or infinity and exp is unspecified as a result. | | ||
| test.c:64:3:64:7 | call to atanh | Pole error in call to 'atanh': argument is plus or minus 1. | | ||
| test.c:65:3:65:7 | call to atanh | Pole error in call to 'atanh': argument is plus or minus 1. | | ||
| test.c:66:3:66:5 | call to log | Pole error in call to 'log': argument is equal to zero. | | ||
| test.c:67:3:67:7 | call to log10 | Pole error in call to 'log10': argument is equal to zero. | | ||
| test.c:68:3:68:6 | call to log2 | Pole error in call to 'log2': argument is equal to zero. | | ||
| test.c:69:3:69:7 | call to log1p | Pole error in call to 'log1p': argument is equal to negative one. | | ||
| test.c:71:3:71:5 | call to pow | Pole error in call to 'pow': base is zero and exp is negative. | | ||
| test.c:72:3:72:8 | call to lgamma | Pole error in call to 'lgamma': argument is equal to zero. | |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
- `A0-4-4`,`FLP32-C` - `UncheckedRangeDomainPoleErrors.ql`: | ||
- Fixes #193. Adds missing cases for domain errors, an unspecified result case and pole error cases. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 30 additions & 18 deletions
48
cpp/common/test/rules/uncheckedrangedomainpoleerrors/UncheckedRangeDomainPoleErrors.expected
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,30 @@ | ||
| test.cpp:4:3:4:6 | call to acos | Domain error in call to acos: the argument has a range -1.1...-1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.cpp:8:3:8:6 | call to acos | Domain error in call to acos: the argument has a range 1.1...1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.cpp:9:3:9:6 | call to asin | Domain error in call to asin: the argument has a range -1.1...-1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.cpp:13:3:13:6 | call to asin | Domain error in call to asin: the argument has a range 1.1...1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.cpp:14:3:14:7 | call to atanh | Domain error in call to atanh: the argument has a range -1.1...-1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.cpp:18:3:18:7 | call to atanh | Domain error in call to atanh: the argument has a range 1.1...1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.cpp:19:3:19:7 | call to atan2 | Domain error in call to atan2: both arguments are equal to zero. | | ||
| test.cpp:23:3:23:5 | call to pow | Domain error in call to pow: both arguments are equal to zero. | | ||
| test.cpp:27:3:27:5 | call to pow | Domain error in call to pow: both arguments are less than zero. | | ||
| test.cpp:33:3:33:7 | call to acosh | Domain error in call to acosh: argument is less than 1. | | ||
| test.cpp:34:3:34:7 | call to ilogb | Domain error in call to ilogb: argument is equal to zero. | | ||
| test.cpp:37:3:37:5 | call to log | Domain error in call to log: argument is negative. | | ||
| test.cpp:40:3:40:7 | call to log10 | Domain error in call to log10: argument is negative. | | ||
| test.cpp:43:3:43:6 | call to log2 | Domain error in call to log2: argument is negative. | | ||
| test.cpp:46:3:46:6 | call to sqrt | Domain error in call to sqrt: argument is negative. | | ||
| test.cpp:49:3:49:7 | call to log1p | Domain error in call to log1p: argument is less than 1. | | ||
| test.cpp:52:3:52:6 | call to logb | Domain error in call to logb: argument is equal to zero. | | ||
| test.cpp:55:3:55:8 | call to tgamma | Domain error in call to tgamma: argument is equal to zero. | | ||
| test.cpp:5:3:5:6 | call to acos | Domain error in call to 'acos': the argument has a range -1.1...-1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.cpp:9:3:9:6 | call to acos | Domain error in call to 'acos': the argument has a range 1.1...1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.cpp:10:3:10:6 | call to asin | Domain error in call to 'asin': the argument has a range -1.1...-1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.cpp:14:3:14:6 | call to asin | Domain error in call to 'asin': the argument has a range 1.1...1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.cpp:15:3:15:7 | call to atanh | Domain error in call to 'atanh': the argument has a range -1.1...-1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.cpp:17:3:17:7 | call to atanh | Domain error in call to 'atanh': the argument has a range 1.1...1.1 which is outside the domain of this function (-1.0...1.0). | | ||
| test.cpp:18:3:18:7 | call to atan2 | Domain error in call to 'atan2': both arguments are equal to zero. | | ||
| test.cpp:22:3:22:5 | call to pow | Domain error in call to 'pow': both arguments are equal to zero. | | ||
| test.cpp:26:3:26:5 | call to pow | Domain error in call to 'pow': both arguments are less than zero. | | ||
| test.cpp:31:3:31:7 | call to acosh | Domain error in call to 'acosh': argument is less than 1. | | ||
| test.cpp:32:3:32:7 | call to ilogb | Domain error in call to 'ilogb': argument is equal to zero. | | ||
| test.cpp:35:3:35:5 | call to log | Domain error in call to 'log': argument is negative. | | ||
| test.cpp:37:3:37:7 | call to log10 | Domain error in call to 'log10': argument is negative. | | ||
| test.cpp:39:3:39:6 | call to log2 | Domain error in call to 'log2': argument is negative. | | ||
| test.cpp:41:3:41:6 | call to sqrt | Domain error in call to 'sqrt': argument is negative. | | ||
| test.cpp:44:3:44:7 | call to log1p | Domain error in call to 'log1p': argument is less than 1. | | ||
| test.cpp:46:3:46:6 | call to logb | Domain error in call to 'logb': argument is equal to zero. | | ||
| test.cpp:49:3:49:8 | call to tgamma | Domain error in call to 'tgamma': argument is equal to zero. | | ||
| test.cpp:55:3:55:5 | call to abs | Range error in call to 'abs': argument is most negative number. | | ||
| test.cpp:56:3:56:6 | call to fmod | Domain error in call to 'fmod': y is 0. | | ||
| test.cpp:58:3:58:7 | call to frexp | Unspecified error in call to 'frexp': Arg is Nan or infinity and exp is unspecified as a result. | | ||
| test.cpp:59:3:59:7 | call to frexp | Unspecified error in call to 'frexp': Arg is Nan or infinity and exp is unspecified as a result. | | ||
| test.cpp:63:3:63:7 | call to atanh | Pole error in call to 'atanh': argument is plus or minus 1. | | ||
| test.cpp:64:3:64:7 | call to atanh | Pole error in call to 'atanh': argument is plus or minus 1. | | ||
| test.cpp:65:3:65:5 | call to log | Pole error in call to 'log': argument is equal to zero. | | ||
| test.cpp:66:3:66:7 | call to log10 | Pole error in call to 'log10': argument is equal to zero. | | ||
| test.cpp:67:3:67:6 | call to log2 | Pole error in call to 'log2': argument is equal to zero. | | ||
| test.cpp:68:3:68:7 | call to log1p | Pole error in call to 'log1p': argument is equal to negative one. | | ||
| test.cpp:70:3:70:5 | call to pow | Pole error in call to 'pow': base is zero and exp is negative. | | ||
| test.cpp:71:3:71:8 | call to lgamma | Pole error in call to 'lgamma': argument is equal to zero. | |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the imprecision of floating points we can't compare them like this.
You need to subtract them and check whether their absolute value is smaller than some epsilon.