Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java/Kotlin: Remove support for some deprecated environment variables #16401

Merged
merged 5 commits into from
May 10, 2024
Merged

Java/Kotlin: Remove support for some deprecated environment variables #16401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
231918f
Kotlin: Remove redundant variable ODASA_JAVA_LAYOUT
igfoo May 2, 2024
304ad33
Kotlin: Remove unused ODASA_TOOLS variable
igfoo May 2, 2024
cfc419b
Kotlin: Remove unused ODASA_HOME variable
igfoo May 2, 2024
b5d6bb9
Kotlin: Remove unused var SEMMLE_PLATFORM_TOOLS
igfoo May 2, 2024
4d54c09
Java: Add changenote for dropping support for some old variables
igfoo May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 0 additions & 17 deletions java/kotlin-extractor/src/main/java/com/semmle/util/process/Env.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,6 @@ public enum Var {
/*
* Core toolchain variables
*/
/**
* The location of the toolchain.
*
* Deprecated in favour of {@link Var#SEMMLE_DIST}, {@link Var#SEMMLE_HOME}, and
* {@link Var#SEMMLE_DATA}.
*/
@Deprecated
ODASA_HOME,
/**
* The location of the user's configuration files, including project configurations,
* dashboard configurations, team insight configurations, licenses etc.
Expand Down Expand Up @@ -82,10 +74,6 @@ public enum Var {
* The location where our queries are kept.
*/
ODASA_QUERIES,
/**
* The location of the 'tools' directory
*/
ODASA_TOOLS,
/**
* Whether we are running in 'prototyping mode'.
*/
Expand Down Expand Up @@ -197,10 +185,6 @@ public enum Var {
* The platform we are running on; one of "linux", "osx" and "win".
*/
SEMMLE_PLATFORM,
/**
* Location of platform specific tools, currently only used in universal LGTM distributions
*/
SEMMLE_PLATFORM_TOOLS,
/**
* PATH to use to look up tooling required by macOS Relocator scripts.
*/
Expand Down Expand Up @@ -284,7 +268,6 @@ public enum Var {
/*
* Layout variables
*/
ODASA_JAVA_LAYOUT,
ODASA_CPP_LAYOUT,
ODASA_CSHARP_LAYOUT,
ODASA_PYTHON_LAYOUT,
Expand Down
4 changes: 4 additions & 0 deletions java/ql/lib/change-notes/2024-05-02-env-vars.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: breaking
---
* The Java extractor no longer supports the `ODASA_JAVA_LAYOUT`, `ODASA_TOOLS` and `ODASA_HOME` legacy environment variables.