Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: fix models for built-in functions #16413

Merged
merged 16 commits into from
May 14, 2024
Merged

Commits on May 10, 2024

  1. Configuration menu
    Copy the full SHA
    e857eed View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1322ce3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fcdac0a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f95ccd2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    84b7319 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c816412 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    eab1569 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    86e2b84 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    d5aa08d View commit details
    Browse the repository at this point in the history
  10. Add change note

    owen-mc committed May 10, 2024
    Configuration menu
    Copy the full SHA
    8cc9838 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    e1c85e3 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    7694618 View commit details
    Browse the repository at this point in the history
  13. Accept expected test changes

    owen-mc committed May 10, 2024
    Configuration menu
    Copy the full SHA
    f8e17fe View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    f7e6bf7 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Fix models for min and max and improve tests

    Although the documentation makes them look variadic (and generic), they
    are actually special-cased in the compiler. Like all built-in functions
    they don't have a signature type, but the type of `min(a, b, c)` is
    `func(int, int, int) int` and not `func(int, ...int) int`.
    
    Go doesn't allow open-ended ranges for argument indices in
    models-as-data specifications (though Ruby and Python do), so I've used
    `1..1000`.
    owen-mc committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ab5e1f8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    827d15a View commit details
    Browse the repository at this point in the history