Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: Fix test expectations #16464

Merged
merged 1 commit into from
May 9, 2024
Merged

Go: Fix test expectations #16464

merged 1 commit into from
May 9, 2024

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented May 9, 2024

I'm pretty sure this is what happened:

This will be fixed when #16413 is merged, which removes the old-style models. (Both of the above PRs were bug-fixes that I pulled out of #16413.)

@owen-mc owen-mc requested a review from a team as a code owner May 9, 2024 15:27
@github-actions github-actions bot added the Go label May 9, 2024
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as CI passes.

@owen-mc owen-mc merged commit e721399 into github:main May 9, 2024
10 checks passed
@owen-mc owen-mc deleted the go/fix-broken-test branch May 9, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants