New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cleanup example to use pull_request_target trigger #31322
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@Mogyuchi Thanks so much for opening a PR! I'll get this triaged for review ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this change and it does not fix the issue unfortunately
I still get the same error, at least when triggering manually (having added workflow_dispatch:
to do so)
Maybe that's as expected, maybe the permissions are only granted when you merge a PR, hard to tell/test
I see, the right permissions might be auto-granted due to this change:
When a workflow is triggered by the pull_request_target event, the GITHUB_TOKEN is granted read/write repository permission, even when it is triggered from a public fork. For more information, see "Events that trigger workflows."
https://docs.github.com/en/actions/security-guides/automatic-token-authentication#permissions-for-the-github_token
I've added explicit token permissions in #31582, this allowed me to test via workflow_dispatch:
No… I think we should use " |
Closing this PR. See my comment here. Our team will make some improvements to this article internally. Thanks everyone! |
Why:
Closes: #31321
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.