New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update about-tracks-and-tracked-by-fields.md #32750
Conversation
- **Minor copy edits.** - **Minor formatting tweaks.** Mostly to do with making “Tracked by” into “**Tracked by**”, since it is easy to forget this is a 2-word label because the second word is not capitalized. (So you can read a few words beyond this before realizing your brain didn’t parse the end of the label correctly, so you backtrack and reread… etc…)
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
This comment was marked as spam.
This comment was marked as spam.
@Zearin Thanks so much for opening a PR! I'll get this triaged for review ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Zearin, I agree with the logic behind your changes. The only thing is that our style guide says:
Use bold to describe UI elements that can be interacted with.
(Ref)
And:
When referencing text in the user interface, reproduce the text exactly. Use quotation marks to surround UI text that cannot be interacted with.
(Ref)
As such, if you can replace the bold with quotation marks (for example You can enable the "Tracks"...
), then I'm happy to approve and merge this 👍
Replaced boldface with quotations for UI elements that can be interacted with, per style guide
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
n/a
What's being changed (if available, include any code snippets, screenshots, or gifs):
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.