Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a topic for Squirrel! #4295

Merged
merged 10 commits into from May 18, 2024
Merged

Add a topic for Squirrel! #4295

merged 10 commits into from May 18, 2024

Conversation

TuberAsk
Copy link
Contributor

@TuberAsk TuberAsk commented Apr 30, 2024

Please confirm this pull request meets the following requirements:


Which change are you proposing?

  • Suggesting edits to an existing topic or collection
  • Curating a new topic or collection
  • Something that does not neatly fit into the binary options above

Curating a new topic or collection

  • I've formatted my changes as a new folder directory, named for the topic or collection as it appears in the URL on GitHub (e.g. https://github.com/topics/[NAME] or https://github.com/collections/[NAME])
  • [] My folder contains a *.png image (if applicable) and index.md
  • [] All required fields in my index.md conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs

Squirrel is really underated, I think it's a great language and if we can make a topic for it, that would have been great. I think it would be cool if more users would notice Squirrel. Squirrel does not use tons of RAM, it is embeddable and lightweight.

@TuberAsk TuberAsk requested a review from a team as a code owner April 30, 2024 21:45
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TuberAsk - Thanks for this contribution! As I put in the review, I don't think you should use the squirrel topic name for this language as it is already in widespread use by a different project.

@@ -0,0 +1,12 @@
---
aliases: squirrel-lang
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the directory name and primary name of this topic should be squirrel-lang , because there is already a different project that is a popular packaging tool at github.com/squirrel , which has 90% of the repos currently under this topic.

Alternately, you could make this file a disambiguation page that follows the pattern at https://github.com/topics/protocol (similar to wikipedia) and add a curation for both squirrel-lang and squirrel-installer

@ahpook
Copy link
Contributor

ahpook commented May 17, 2024

Hi @TuberAsk are you interested in getting this merged? Please see my comments on the review - I think you'll need to rename this directory and top level category to squirrel-lang. I'll close this after next week if you no longer want to work on it.

@TuberAsk
Copy link
Contributor Author

TuberAsk commented May 17, 2024

Hey, I just made the changes! :D

thanks!

@TuberAsk TuberAsk requested a review from ahpook May 17, 2024 23:12
Copy link
Contributor

@ahpook ahpook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@ahpook ahpook added this pull request to the merge queue May 18, 2024
Merged via the queue into github:main with commit e6086ee May 18, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants