New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a topic for Squirrel! #4295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TuberAsk - Thanks for this contribution! As I put in the review, I don't think you should use the squirrel
topic name for this language as it is already in widespread use by a different project.
topics/squirrel/index.md
Outdated
@@ -0,0 +1,12 @@ | |||
--- | |||
aliases: squirrel-lang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the directory name and primary name of this topic should be squirrel-lang
, because there is already a different project that is a popular packaging tool at github.com/squirrel , which has 90% of the repos currently under this topic.
Alternately, you could make this file a disambiguation page that follows the pattern at https://github.com/topics/protocol (similar to wikipedia) and add a curation for both squirrel-lang
and squirrel-installer
Hi @TuberAsk are you interested in getting this merged? Please see my comments on the review - I think you'll need to rename this directory and top level category to |
Hey, I just made the changes! :D thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Please confirm this pull request meets the following requirements:
Which change are you proposing?
Curating a new topic or collection
https://github.com/topics/[NAME]
orhttps://github.com/collections/[NAME]
)*.png
image (if applicable) andindex.md
index.md
conform to the Style Guide and API docs: https://github.com/github/explore/tree/main/docs