New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace destructuring assignment #45

Open

abraham wants to merge 2 commits into gl-vis:master from abraham:ie11

abraham commented Aug 16, 2019

Correct fix for #32 based on gl-vis/regl-scatter2d@734e372

abraham added 2 commits

August 16, 2019 13:21


          Add budo to devDependencies

d06af55


          Replace destructuring assignment

e3f7fbb

dy approved these changes

View reviewed changes

Member

dy commented Aug 16, 2019

@archmoj what would you say?

Contributor

archmoj commented Aug 16, 2019

Cool. Let's test this in plotly.js.
cc: @etpinard

Contributor

archmoj commented Aug 17, 2019

Unfortunately the lines are disappeared after trying this PR:
https://circleci.com/workflow-run/b1163950-30c4-437d-91df-88972bd2eb0e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment