Switch build to rollup to ease integration with other libraries #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lotly custom packages to be build without relsoving glslify file imports
|
Not sure, @archmoj may be you know? I would personally try to just upgrade to esbuild and throw away babels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since i had a lot of trouble with including Plotly JS using ScatterGL Plots into a vite js based project, i noticed that a similar project (regl-scatter2d ) used another bundling based on rollup in order to handle the inclusion of shader code.
Since it worked a lot better, i tried to switch the project over to a rollup-based build and changed the package main file to bundle.js which also includes preprocessed shader code while keeping the project dependencies external.
Does it make sense, to apply this to this repository ?