Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gr_modtool makeyaml produces some invalid fields #5222

Closed
mormj opened this issue Oct 20, 2021 · 3 comments · Fixed by #7354
Closed

gr_modtool makeyaml produces some invalid fields #5222

mormj opened this issue Oct 20, 2021 · 3 comments · Fixed by #7354
Labels
Bug codegen Relating to automatic code generation medium modtool

Comments

@mormj
Copy link
Contributor

mormj commented Oct 20, 2021

What happened?

gr_modtool makeyaml produces some invalid fields due to the regex parsing of the impl files

System Information

OS: Ubuntu 20.10
GR Installation Method: source

GNU Radio Version

3.10-git (master)

Specific Version

395-gc3c411be

Steps to Reproduce the Problem

  1. Create a block with gr_modtool
  2. gr_modtool makeyaml myblock

The output yaml has a few issues - see log output

Relevant log output

id: cudademo_multiply_const
label: multiply const
category: '[Cudademo]'
templates:
  imports: import cudademo
  make: cudademo.multiply_const(${k})
parameters:
- id: k
  label: K
  dtype: float
inputs:
- label: in
  domain: stream
  dtype: raw
  multiplicity: 1 /* max inputs */
outputs:
- label: out
  domain: stream
  dtype: raw
  multiplicity: 1 /*max outputs */
file_format: 1
@mormj mormj added the modtool label Oct 20, 2021
@mormj mormj added this to To do in Release 3.10 via automation Nov 29, 2021
@mormj mormj removed this from To do in Release 3.10 Jan 20, 2022
@mormj mormj added this to To do in Release 3.11 via automation Jan 20, 2022
@mormj mormj moved this from To do to Proposed in Release 3.11 Jan 20, 2022
@catkira
Copy link

catkira commented Jun 6, 2022

I have the same problem, any chance this will be fixed?

@marcusmueller
Copy link
Member

@catkira as soon as someone finds the time to try! Wanna give it a go?

@marcusmueller
Copy link
Member

Still reproduces. Small script to test this (we could upstream that as unit test once gr_modtool can create blocks without QA without manual interaction) included:

https://gist.github.com/marcusmueller/f03ff708e0975c82dc80c06156c1ae3b

@marcusmueller marcusmueller added Bug codegen Relating to automatic code generation and removed good first issue Triage::postponed labels Feb 14, 2024
Release 3.11 automation moved this from Proposed to Done May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug codegen Relating to automatic code generation medium modtool
Projects
Development

Successfully merging a pull request may close this issue.

3 participants