modtool: Remove comments from C++ iosignatures #7354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusmueller
force-pushed
the
modtool_makeyaml_decommentify
branch
from
634e480
to
5bb9d82
Compare
willcode
reviewed
May 18, 2024
willcode
reviewed
May 18, 2024
willcode
reviewed
May 21, 2024
|
@marcusmueller could you squash and sign? |
This makes it possible to use 1 /* number of input streams */ in your code (just as the newmod template does). Signed-off-by: Marcus Müller <mmueller@gnuradio.org>
marcusmueller
force-pushed
the
modtool_makeyaml_decommentify
branch
from
7855aaa
to
1f9f5fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the case where the comments (which are present in gr-newmod) in iosignatures break YAML gen
Related Issue
Fixes #5222
(At least for reasonable cases. Comments with nested comment symbols, or strings containing C comments, might lead to interesting results. But these are not likely to occur.
Which blocks/areas does this affect?
gr-modtool
Testing Done
https://gist.github.com/marcusmueller/f03ff708e0975c82dc80c06156c1ae3b
(can't do automatic tests before we fix modtool to run non-interactively)
Checklist