Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRC: allow variable expressions for enum fields #6991

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AsriFox
Copy link
Contributor

@AsriFox AsriFox commented Dec 5, 2023

Description

Block properties with dtype: enum can now be controlled dynamically by variables or expressions. The evaluated expression is then checked against the enum's options.

Related Issue

Fixes #6870

Which blocks/areas does this affect?

GRC

Testing Done

dvb_enums.grc.txt

Checklist

Fixes gnuradio#6870

Signed-off-by: AsriFox <asrifox@yandex.ru>
@AsriFox
Copy link
Contributor Author

AsriFox commented Dec 5, 2023

Some parameters may benefit from not having this dynamic evaluation, like output_language or generate_options in Options block. This will probably require adding a new hidden dtype.

@willcode
Copy link
Member

Added Needs Action based on the comment above. Should this be changed to draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block properties: allow variable expressions for enum fields
2 participants