-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: use XDG_CONFIG_DIR for the userconf path #7073
base: main
Are you sure you want to change the base?
Conversation
698c773
to
55b75f7
Compare
I like the idea of having the GR conf file use the system scheme. We've got an awful lot of people out there with the conf file in the current location, so I feel like some sort of transition is needed. That might involve the old location having priority, or copying the file to the new location (and removing the old one?) or something else. Then there's the user "where did my file go?" problem. Needs some thought. |
@mboersch would you please run clang-format on your changed files? @willcode I think for The backport to maint-3.10 (which sadly is explicitly necessary, if we want to do it, because these functions are public API…) would probably want to not do anything "automatically surprising" about the file(s)'s location, fully agreed. But we could print a nice log entry, and I wouldn't mind adding a GRC button that does move the configuration, abusing, say, the "Help" menu. |
Things that are |
This changes the config path from ~/.gnuradio to ~/.config/gnuradio. On windows this maps to %APPDATA%/.config/gnuradio. Signed-off-by: M. Boerschig <code-gnuradio@yoyomail.de>
55b75f7
to
bbb02af
Compare
Done. Some backwards compatibility seems reasonable -- even though that code would probably live forever. I can try add a lookup to the old |
Throwing in, a change to only using the XDG path is reasonable for GR 4. I agree backwards compatibility/transitioning is needed or we'll substantially confuse folks doing upgrades. |
Marked with "API Change" so we track that we need to think of a way to make this backward compatible. |
Setting as Draft until backward compatibility is worked out. |
This changes the config path from ~/.gnuradio to ~/.config/gnuradio. On windows this maps to %APPDATA%/.config/gnuradio.
This was requested in #3631.
Description
Adhering to the XDG specification help reduce clutter of custom dotfile locations in $HOME...
Related Issue
Fixes #3631
Which blocks/areas does this affect?
runtime
Testing Done
CMake build and ctest.
Checklist
Not sure how I should document this or where to even start. Dito testing :-)