Update qa_zeromq_pushpull.py with IPV6 test loopback #7320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test_002 with IPV6 loopback address to fix issue "Can't connect to IPv6 host using ZMQ PULL Source gnuradio#1866 "
|
tried fix issue #1866 |
|
Hi! Thanks for tackling this! Two things: you really have to sign-off your commits, as mentioned :) You can sign-off yours using However, I think we need to technically adjust things, as well: |
marcusmueller
requested changes
May 7, 2024
| src_data = list(range(vlen)) * 100 | ||
| src = blocks.vector_source_f(src_data, False, vlen) | ||
| zeromq_push_sink = zeromq.push_sink( | ||
| gr.sizeof_float, vlen, "tcp://0:0:0:0:0:0:0:1") |
There was a problem hiding this comment.
This doesn't look like a valid IPv6 pseudo-URL; tcp://[::1] should be valid. Because of the ambiguity caused by : in IPv6 addresses and the port specification, IPv6 addresses in URLs are typically represened as bracketed.
willcode
added
CI
network
Needs Action
Backport-3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test_002 with IPV6 loopback address to fix issue "Can't connect to IPv6 host using ZMQ PULL Source #1866 "
Description
Related Issue
Which blocks/areas does this affect?
Testing Done
Checklist