Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document Metal support in Internal rendering architecture #9385

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Document Metal support in Internal rendering architecture #9385

wants to merge 1 commit into from
+31 −22

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 16, 2024

@Calinou Calinou added enhancement area:contributing Issues and PRs related to the Contributing/Development section of the documentation waiting on PR merge PR's that can't be merged until a engine PR is merged first topic:rendering labels May 16, 2024
@Calinou Calinou mentioned this pull request May 16, 2024
Open
@Calinou Calinou force-pushed the internal-rendering-architecture-metal branch from b5d2dc4 to e2b2752 Compare May 20, 2024 19:38
@Calinou Calinou force-pushed the internal-rendering-architecture-metal branch from e2b2752 to fce5e23 Compare May 20, 2024 19:39
Calinou
Calinou commented May 31, 2024
View reviewed changes
contributing/development/core_and_modules/internal_rendering_architecture.rst
Comment on lines +217 to +219
:ref:`doc_internal_rendering_architecture_core_shaders` are shared with the
Vulkan renderer. Shaders are transpiled from GLSL to :abbr:`MSL (Metal Shading Language)`
using SPIRV-Cross.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stuartcarnie Is this paragraph correct? Does Metal have something akin to SPIR-V or DXIL that would be used as a transpiling target?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that paragraph is correct. There is not a documented intermediate representation, however, shaders can be compiled to an IR, which is compiled on the hardware when used. We would have to use the Metal compiler tools to generate the IR from Metal Shader Language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartcarnie stuartcarnie stuartcarnie left review comments

Assignees
No one assigned
Labels
area:contributing Issues and PRs related to the Contributing/Development section of the documentation enhancement topic:rendering waiting on PR merge PR's that can't be merged until a engine PR is merged first
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Calinou @stuartcarnie