Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support status codes 302 and 200 in GetArchiveLink endpoint #3172

Merged
merged 1 commit into from
May 16, 2024

Conversation

assembly-winston
Copy link
Contributor

Fixes: #3171

Copy link

google-cla bot commented May 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gmlewis gmlewis changed the title GetArchiveLink returns a status code 200, not 302, when link is requested with an installation token rather than personal/bearer token Support status code 302 and 200 in GetArchiveLink endpoint May 16, 2024
@gmlewis gmlewis changed the title Support status code 302 and 200 in GetArchiveLink endpoint Support status codes 302 and 200 in GetArchiveLink endpoint May 16, 2024
@gmlewis gmlewis added NeedsReview PR is awaiting a review before merging. waiting for signed CLA labels May 16, 2024
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @assembly-winston !
LGTM.

Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Also awaiting signed CLA before proceeding.

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.93%. Comparing base (2b8c7fa) to head (a3269f2).
Report is 62 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3172      +/-   ##
==========================================
- Coverage   97.72%   92.93%   -4.79%     
==========================================
  Files         153      171      +18     
  Lines       13390    11542    -1848     
==========================================
- Hits        13085    10727    -2358     
- Misses        215      724     +509     
- Partials       90       91       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@assembly-winston
Copy link
Contributor Author

Signed CLA!

@gmlewis gmlewis removed waiting for signed CLA NeedsReview PR is awaiting a review before merging. labels May 16, 2024
@gmlewis
Copy link
Collaborator

gmlewis commented May 16, 2024

OK, I'm going to override the normal policy of a second LGTM for this simple change (similar to adding a field to a struct) and go ahead and merge.

@gmlewis gmlewis merged commit 0a8878b into google:master May 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants