Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move RequestUserAgent to internal/useragent #981

Closed
wants to merge 2 commits into from

Conversation

cuixq
Copy link
Contributor

@cuixq cuixq commented May 15, 2024

No description provided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know how you feel about this new location.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From an external perspective, this would prevent Scorecard from setting a user agent, which I thought Rex had mentioned a bit back. If that's the direction the team wants to go, I'll close out our corresponding issue.
ossf/scorecard#4029

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes and I also noticed that this won't solve our problem of import cycle so I marked this PR to draft

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2024

Codecov Report

Attention: Patch coverage is 64.70588% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 64.03%. Comparing base (055ef05) to head (64ea62f).

Files Patch % Lines
internal/resolution/client/npm_registry_client.go 0.00% 2 Missing ⚠️
pkg/osv/osv.go 66.66% 2 Missing ⚠️
pkg/osvscanner/osvscanner.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #981      +/-   ##
==========================================
- Coverage   64.63%   64.03%   -0.60%     
==========================================
  Files         146      146              
  Lines        9308    11977    +2669     
==========================================
+ Hits         6016     7670    +1654     
- Misses       2838     3854    +1016     
+ Partials      454      453       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cuixq cuixq marked this pull request as draft May 15, 2024 10:35
@cuixq cuixq closed this May 23, 2024
@cuixq cuixq deleted the useragent branch May 23, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants