Document the properties of a high quality OSV record #2193
+115
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewpollock
force-pushed
the
document_quality_bar
branch
from
e64bb03
to
12cd78b
Compare
darakian
reviewed
May 30, 2024
darakian
reviewed
May 30, 2024
darakian
reviewed
May 30, 2024
chrisbloom7
reviewed
May 31, 2024
Co-authored-by: Jon <darakian@github.com>
Feedback was that it was possible to perceive this as known unfixed vulnerabilities as being of lower quality than ones with known/available fixes, and that is not the case, as such known unfixed vulnerabilities can and do legitimately exist (as is the case when the vulnerable package is orphaned). These are a legitimate true positive with no available fixed version.
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Reviewer feedback.
…ev into document_quality_bar
"Managing the Perishability of OSV Records" is in the early ideation phase.
Thanks @chrisbloom7 I really appreciate you and @darakian taking the time to give it a thorough review, it's all the better for your time and effort. |
andrewpollock
requested review from
oliverchang,
another-rex,
darakian and
chrisbloom7
Co-authored-by: Jon <darakian@github.com>
Feedback was that it was possible to perceive this as known unfixed vulnerabilities as being of lower quality than ones with known/available fixes, and that is not the case, as such known unfixed vulnerabilities can and do legitimately exist (as is the case when the vulnerable package is orphaned). These are a legitimate true positive with no available fixed version.
Reviewer feedback.
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
Co-authored-by: Chris Bloom <chrisbloom7@github.com>
"Managing the Perishability of OSV Records" is in the early ideation phase.
I realised I'd omitted the `events[]` array in the JSON path when talking about `introduced` and `fixed`/`last_affected`. Explicitly refer to commits *and* versions when discussing temporal ordering of `introduced` and `fixed`/`last_affected`.
…ev into document_quality_bar
SecurityCRob
approved these changes
Jun 7, 2024
Based on feedback from Duy Truong about Android's patching approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference from existing documentation on data.
Part of #2186