Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add better autocompletion on block comments #168

Merged

Conversation

spotandjake
Copy link
Member

This pr adds better autocomplete on block comments not to be confused with doc comments.

We now support the auto adding of * when your in a block comment which we previously only did in doc comments. we also now auto-close a block comment for you.

@spotandjake spotandjake added the enhancement New feature or request label Feb 15, 2024
@spotandjake spotandjake self-assigned this Feb 15, 2024
@phated
Copy link
Member

phated commented Feb 22, 2024

formatting looks to be failing

phated
phated previously requested changes Mar 3, 2024
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block comments aren't supposed to have the star on each line.

@spotandjake spotandjake closed this Mar 4, 2024
@phated
Copy link
Member

phated commented Mar 4, 2024

We can still auto-close the */ but I just didn't want the * added to each line 🤷

@spotandjake spotandjake reopened this Mar 4, 2024
@spotandjake
Copy link
Member Author

We can still auto-close the */ but I just didn't want the * added to each line 🤷

Ah okay, I changed that

@ospencer ospencer requested a review from phated March 4, 2024 16:17
@ospencer ospencer dismissed phated’s stale review March 4, 2024 16:17

Resolved by Jake

@ospencer ospencer merged commit c6e141a into grain-lang:main Mar 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants