Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exceptions in the Err case of Number.parseInt #1057

Closed
ospencer opened this issue Dec 8, 2021 · 3 comments · Fixed by #1755
Closed

Use exceptions in the Err case of Number.parseInt #1057

ospencer opened this issue Dec 8, 2021 · 3 comments · Fixed by #1755
Assignees
Labels

Comments

@ospencer
Copy link
Member

ospencer commented Dec 8, 2021

Right now the errors are just plain strings. It'd be more useful if they were exceptions we could pattern match on.

Blocked on #1053

@phated
Copy link
Member

phated commented Jan 22, 2023

This is unblocked because Result is available as a language-supplied type now.

@spotandjake
Copy link
Member

spotandjake commented Mar 18, 2023

This has been blocked by #1758 or #1759 either one would allow this to move forward.

A decision was made to use enums in the case of exceptions the reason this is blocked is because you cannot re-export the enum to get this working properly.

@spotandjake
Copy link
Member

We are going to switch this back to using an enum instead of an exception which means this is blocked on #1886

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants