feat(stdlib): Number.parseInt #1051

ospencer · 2021-12-07T01:16:47Z

What it says on the tin.

phated

Loving it ❤️ A few things

compiler/test/stdlib/number.test.gr

stdlib/number.gr

stdlib/runtime/stringUtils.gr

phated · 2021-12-07T01:32:28Z

stdlib/runtime/stringUtils.gr

+  let radix = WasmI32.fromGrain(radix)
+  let result = if (WasmI32.eqz(radix & Tags._GRAIN_NUMBER_TAG_MASK) || radix < WasmI32.fromGrain(2) || radix > WasmI32.fromGrain(36)) {
+    Memory.incRef(WasmI32.fromGrain(Err))
+    Err("Radix must be an integer between 2 and 36")


Do we want exception types for this?

Only reason I'm a no is because we don't have a great way to re-export exceptions right now. I think there's an issue for that.

Can you open an issue to do this once that issue is solved? Also verify that issue exists 😛

stdlib/runtime/stringUtils.gr

Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>

phated

Approved! Awesome work 🍻

marcusroberts

Looks excellent!

giluis · 2022-03-29T08:56:49Z

Hello everyone, new here.
In the tests in number.test.gr why use assert Number.parseInt("ZYXW44AB", 36) == Ok(2818805666483) for Ok results, but assert Result.isErr(Number.parseInt("", 10)) for Err results?

Wouldn't assert Number.parseInt("abc",10) == Err("Some error message") make more sense consistency-wise (if the language allows for this, not sure it does)?

phated · 2022-03-29T19:30:43Z

Hey @giluis - the reason for the tests written in that fashion is that you shouldn't pattern match on a string inside of Err. The string is just an error message and isn't considered during semantic versioning.

feat(stdlib): Number.parseInt

b4cefb3

ospencer requested a review from a team December 7, 2021 01:16

ospencer self-assigned this Dec 7, 2021

phated reviewed Dec 7, 2021

View reviewed changes

ospencer and others added 3 commits December 6, 2021 20:43

Add tests for more invalid radixes

1a128a3

Update stdlib/number.gr

a3d5780

Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>

Update stdlib/runtime/stringUtils.gr

f72f3bb

Co-authored-by: Blaine Bublitz <blaine.bublitz@gmail.com>

phated approved these changes Dec 7, 2021

View reviewed changes

marcusroberts approved these changes Dec 7, 2021

View reviewed changes

ospencer merged commit abafb58 into main Dec 8, 2021

ospencer deleted the oscar/parseint branch December 8, 2021 18:09

github-actions bot mentioned this pull request May 31, 2022

chore: release main #1292

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(stdlib): Number.parseInt #1051

feat(stdlib): Number.parseInt #1051

ospencer commented Dec 7, 2021

phated left a comment

phated Dec 7, 2021

ospencer Dec 7, 2021

phated Dec 7, 2021

ospencer Dec 8, 2021

phated left a comment

marcusroberts left a comment

giluis commented Mar 29, 2022 •

edited

phated commented Mar 29, 2022

feat(stdlib): Number.parseInt #1051

feat(stdlib): Number.parseInt #1051

Conversation

ospencer commented Dec 7, 2021

phated left a comment

Choose a reason for hiding this comment

phated Dec 7, 2021

Choose a reason for hiding this comment

ospencer Dec 7, 2021

Choose a reason for hiding this comment

phated Dec 7, 2021

Choose a reason for hiding this comment

ospencer Dec 8, 2021

Choose a reason for hiding this comment

phated left a comment

Choose a reason for hiding this comment

marcusroberts left a comment

Choose a reason for hiding this comment

giluis commented Mar 29, 2022 • edited

phated commented Mar 29, 2022

giluis commented Mar 29, 2022 •

edited