Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stdlib): Immutable array #1477

Merged
merged 7 commits into from
Dec 10, 2022
Merged

feat(stdlib): Immutable array #1477

merged 7 commits into from
Dec 10, 2022

Conversation

alex-snezhko
Copy link
Member

An efficient immutable array implementation based off of Elm's Array. For the most part the API is the same as Array with a few exceptions to fit in with immutability.

@ospencer ospencer requested a review from a team November 12, 2022 02:05
ospencer
ospencer reviewed Nov 12, 2022
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll get you a proper, full review, but from just a cursory look, this looks stunning 🤩

ospencer
ospencer reviewed Dec 4, 2022
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic! Just a few nits on comment style and one question about set.

compiler/test/stdlib/immutablearray.test.gr Show resolved Hide resolved
stdlib/immutablearray.gr Outdated Show resolved Hide resolved
stdlib/immutablearray.gr Outdated Show resolved Hide resolved
stdlib/immutablearray.gr Outdated Show resolved Hide resolved
stdlib/immutablearray.gr Outdated Show resolved Hide resolved
stdlib/immutablearray.gr Outdated Show resolved Hide resolved
stdlib/immutablearray.gr Outdated Show resolved Hide resolved
phated
phated requested changes Dec 8, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the series of single comments. I was told that I probably wouldn't have feedback, so I started and didn't stop.

phated
phated requested changes Dec 9, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few more things

stdlib/immutablearray.gr Show resolved Hide resolved
stdlib/immutablearray.gr Show resolved Hide resolved
stdlib/immutablearray.gr Outdated Show resolved Hide resolved
stdlib/immutablearray.gr Outdated Show resolved Hide resolved
stdlib/immutablearray.gr Outdated Show resolved Hide resolved
stdlib/immutablearray.gr Show resolved Hide resolved
stdlib/immutablearray.md Outdated Show resolved Hide resolved
stdlib/immutablearray.md Outdated Show resolved Hide resolved
ospencer
ospencer approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@ospencer ospencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @alex-snezhko!

phated
phated requested changes Dec 10, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just doc nits that I'm going to apply

stdlib/immutablearray.gr Outdated Show resolved Hide resolved
stdlib/immutablearray.gr Outdated Show resolved Hide resolved
phated
phated reviewed Dec 10, 2022
View reviewed changes
stdlib/immutablearray.md Outdated Show resolved Hide resolved
phated
phated reviewed Dec 10, 2022
View reviewed changes
stdlib/immutablearray.md Outdated Show resolved Hide resolved
phated
phated approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@phated phated merged commit a34d8b9 into grain-lang:main Dec 10, 2022
@github-actions github-actions bot mentioned this pull request Dec 10, 2022
Merged
@alex-snezhko alex-snezhko mentioned this pull request Dec 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusroberts marcusroberts marcusroberts left review comments

@phated phated phated approved these changes

@ospencer ospencer ospencer approved these changes

Assignees

@alex-snezhko alex-snezhko

Labels
None yet
Projects
No open projects
Grain v0.6.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alex-snezhko @phated @ospencer @marcusroberts