Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler)!: Require extension when including relative file paths #1842

Merged
merged 4 commits into from Mar 3, 2024
Merged

feat(compiler)!: Require extension when including relative file paths #1842

merged 4 commits into from Mar 3, 2024

Conversation

alex-snezhko
Copy link
Member

Requires local included files to be specified with their file extension.

include "list"
include "list.gr" // error
include "./b.gr"
include "./b.whatever"
include "./b" // error if file is b.gr

Closes #1797

peblair
peblair reviewed Jun 12, 2023
View reviewed changes
Copy link
Member

@peblair peblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good! One small request

compiler/src/typed/module_resolution.re Show resolved Hide resolved
spotandjake
spotandjake approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@spotandjake spotandjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@spotandjake spotandjake mentioned this pull request Aug 20, 2023
Closed
@ospencer
Copy link
Member

@alex-snezhko Can you resolve the conflicts here?

ospencer
ospencer reviewed Feb 29, 2024
View reviewed changes
compiler/src/typed/module_resolution.re Outdated Show resolved Hide resolved
compiler/src/typed/module_resolution.re Outdated Show resolved Hide resolved
@phated phated requested a review from ospencer March 2, 2024 22:04
@phated
Copy link
Member

phated commented Mar 2, 2024

@alex-snezhko looks like the reason formatter needs to be run

@phated phated changed the title feat(compiler)!: Require extension for included local files feat(compiler)!: Require extension when including relative file paths Mar 2, 2024
@phated phated enabled auto-merge March 2, 2024 22:58
@phated phated added this pull request to the merge queue Mar 2, 2024
Merged via the queue into grain-lang:main with commit dde62d3 Mar 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peblair peblair peblair left review comments

@phated phated phated approved these changes

@ospencer ospencer ospencer approved these changes

@spotandjake spotandjake spotandjake approved these changes

@jozanza jozanza Awaiting requested review from jozanza jozanza is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

Assignees

@alex-snezhko alex-snezhko

Labels
compiler
Projects
No open projects
Grain v0.6.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler: Require extensions for local include paths
5 participants
@alex-snezhko @ospencer @phated @peblair @spotandjake