feat(stdlib): Add More String Iteration Functions #1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
phated,
peblair,
marcusroberts and
jozanza
as code owners
stdlib/string.gr
Outdated
| * @since v0.6.0 | ||
| */ | ||
| @unsafe | ||
| provide let forEachChar = (fn: Char -> Void, str: String) => { |
There was a problem hiding this comment.
You could probably share some code between this function and forEachCodePoint; same with forEachChari
There was a problem hiding this comment.
I made the idx change, but I dont think it is optimial to share code here, the type signatures of fn are different so its not as simple as just having a bool that says to use char or code point. meaning you would need to use a wrapper function into the helper that tags the char, which it invokes an extra function call. On another note if we do want to go this route we might as well justhave a forEachCodePointIHelper which returns an unsafe code point. and then each function just becomes forEachCodePointIHelper((c, _) => fn(tagChar(c)), str).
spotandjake
force-pushed
the
spotandjake-string-funcs
branch
from
bf351f2
to
f9d7abb
Compare
alex-snezhko
approved these changes
Jan 22, 2024
spotandjake
force-pushed
the
spotandjake-string-funcs
branch
from
ab94524
to
36318b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds
forEachChar,forEachCharI,mapandmapito the String library.