Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): Ensure reprovided types unify #2051

Merged
merged 1 commit into from Mar 2, 2024
Merged

fix(compiler): Ensure reprovided types unify #2051

merged 1 commit into from Mar 2, 2024

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented Mar 2, 2024

Closes #1886

Shoutout to @peblair for the type manifest idea.

@ospencer ospencer self-assigned this Mar 2, 2024
peblair
peblair approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@peblair peblair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The power of manifestation

@phated phated added this pull request to the merge queue Mar 2, 2024
Merged via the queue into main with commit 4c3203c Mar 2, 2024
12 checks passed
@phated phated deleted the oscar/reprovide-type-unify branch March 2, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@peblair peblair peblair approved these changes

@alex-snezhko alex-snezhko Awaiting requested review from alex-snezhko alex-snezhko is a code owner

Assignees

@ospencer ospencer

Labels
None yet
Projects
No open projects
Grain v0.6.0
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lang: re-provided type from one module incompatible with origin module
3 participants
@ospencer @phated @peblair