Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(compiler): Remove unnecessary fix_blocks in parser #2052

Merged
merged 1 commit into from Mar 2, 2024
Merged

chore(compiler): Remove unnecessary fix_blocks in parser #2052

merged 1 commit into from Mar 2, 2024

Conversation

ospencer
Copy link
Member

@ospencer ospencer commented Mar 2, 2024

No description provided.

@ospencer ospencer self-assigned this Mar 2, 2024
phated
phated approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was this for in the past?

@ospencer
Copy link
Member Author

ospencer commented Mar 2, 2024

The fix_tyvar_mapper was from before we used Menhir and couldn't properly distinguish between constructors and other values. The fix_blocks construct was from the very early days of Grain when we had let foo = ... in syntax...

@phated phated enabled auto-merge March 2, 2024 21:31
@phated phated added this pull request to the merge queue Mar 2, 2024
Merged via the queue into main with commit a56ebb6 Mar 2, 2024
12 checks passed
@phated phated deleted the oscar/remove-fix-blocks branch March 2, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phated phated phated approved these changes

@peblair peblair Awaiting requested review from peblair peblair is a code owner

@marcusroberts marcusroberts Awaiting requested review from marcusroberts marcusroberts is a code owner

Assignees

@ospencer ospencer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ospencer @phated