fix(compiler): Fix disambiguation of record label access #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
commented
Mar 16, 2024
| @@ -2592,7 +2592,7 @@ and type_label_access = (env, srecord, lid) => { | |||
| let opath = | |||
| try({ | |||
| let (p0, p, _) = extract_concrete_record(env, ty_exp); | |||
| Some((p0, p, repr(ty_exp).level == generic_level)); | |||
There was a problem hiding this comment.
This has been broken for quite a while, long enough that I'm too lazy to find out. We did some cleanup in #1751 where you can see what the code was before. Most of the logic around principal types was commented out, including a condition that would consider this to be true if principal types were not enabled. I imagine we accidentally commented that out way back in the day.
phated
approved these changes
Mar 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.