fix(compiler): Stabilize CRC checks #2101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ospencer
force-pushed
the
oscar/investigate-crcs
branch
from
1bd42d5
to
fb3bfc2
Compare
ospencer
force-pushed
the
oscar/investigate-crcs
branch
from
fb3bfc2
to
1b42b44
Compare
marcusroberts
approved these changes
Apr 26, 2024
phated
approved these changes
Apr 27, 2024
Comment on lines
165
to
+166
| /* Is this okay? This causes serialized type variables to lose their proper IDs. -Oscar */ | ||
| /* if s.for_saving || ty.id < 0 then */ | ||
| if (s.for_saving) { | ||
| /* if s.for_cmi || ty.id < 0 then */ |
There was a problem hiding this comment.
Still haven't answered this question? 😛
There was a problem hiding this comment.
No 😛
Theoretically if we ever figured this out we wouldn't need the Translsig module. I think? The world may never know 🙈
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1843
Ensures we always are keying off of object name & removes cache for out-of-date objects. Also ensures consistent CMIs on the first & subsequent builds.