Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package.json): update test commands #833

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Realtin
Copy link
Member

@Realtin Realtin commented Jul 2, 2018

to always run pretest command

 to always run pretest command
@Realtin Realtin requested a review from hulkoba July 2, 2018 11:50
Copy link
Contributor

@hulkoba hulkoba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test:sequential needs the NODE_ENV=testing

@@ -73,11 +73,10 @@
"format": "prettier-standard-formatter jobs lib test",
"db:start": "./start-couchdb",
"deploy": "./deploy",
"pretest": "standard && npm run db:start",
"pretest": "standard && npm run db:start NODE_ENV=testing",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why put NODE_ENV=testing at the end instead of NODE_ENV=testing npm...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants