fix(input): always call onChange

guilhermerodz · Feb 22, 2024 · 8dbc110 · 8dbc110
1 parent 44f08b7
commit 8dbc110
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/packages/input-otp/src/input.tsx b/packages/input-otp/src/input.tsx
@@ -30,7 +30,15 @@ export const OTPInput = React.forwardRef<HTMLInputElement, OTPInputProps>(
     // Workarounds
     const value = uncheckedValue ?? internalValue
     const previousValue = usePrevious(value)
-    const onChange = uncheckedOnChange ?? setInternalValue
+    const onChange = (newValue: string) => {
+      // Check if input is controlled
+      if (uncheckedValue !== undefined) {
+        uncheckedOnChange?.(newValue)
+      } else {
+        setInternalValue(newValue)
+        uncheckedOnChange?.(newValue)
+      }
+    }
     const regexp = pattern
       ? typeof pattern === 'string'
         ? new RegExp(pattern)

diff --git a/packages/input-otp/src/types.ts b/packages/input-otp/src/types.ts
@@ -8,7 +8,7 @@ export type OTPInputProps = OverrideProps<
   React.InputHTMLAttributes<HTMLInputElement>,
   {
     value?: string
-    onChange?: (...args: any[]) => unknown
+    onChange?: (newValue: string) => unknown
 
     maxLength: number