Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RTL support #26

Closed
wants to merge 5 commits into from
Closed

feat: RTL support #26

wants to merge 5 commits into from

Conversation

vltansky
Copy link

@vltansky vltansky commented Mar 6, 2024

pretty small fix for RTL support by just enforcing it to be LTR as numbers anyway always written left to right.

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rodz-input-otp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 9:43am

@guilhermerodz
Copy link
Owner

guilhermerodz commented Mar 6, 2024

hi @vltansky i would love to add support for RTL, yet I don't know what's a good example for this.

this PR does not affect the input's behavior.
also, please notice the source code is located at packages

can you provide more details on what is the expected behavior when it comes to rtl?

Current behavior is ltr but not specified at CSS level.

@vltansky
Copy link
Author

Hi, I've added an example to switch to RTL/LTR in the demo website.
Also, I've added the style in the right place, my bad :)

before:
https://share.cleanshot.com/9mpvmwsr

after:
https://share.cleanshot.com/yX8bjvt8

it should behave just the same as LTR.

@guilhermerodz
Copy link
Owner

hi @vltansky I'm still not sure how to achieve the behavior you mentioned.

can you provide me with a preview/link?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants